fix(setup): improve timeout handling for certificate generation #2592
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase overall timeout in Initialize function from 2 to 5 minutes - Add 30-second timeout contexts for initialize
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
@zerbitx @FabianKramm Could you please review this? |
|
@mayooot Thanks for the contribution! Some recent changes have removed the polling and gone with a strategy of allowing it to fail on the first error, rather than polling. The timeouts shouldn't be needed anymore. I'm going to close this PR and the issue, but please reopen and tag me if you find it still not working as you would expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind feature
What does this pull request do? Which issues does it resolve?
#2591
Please provide a short message that should be published in the vcluster release notes